Allow matchers to be used in constexpr code#3091
Open
PowellNGL wants to merge 1 commit intocatchorg:develfrom
Open
Allow matchers to be used in constexpr code#3091PowellNGL wants to merge 1 commit intocatchorg:develfrom
PowellNGL wants to merge 1 commit intocatchorg:develfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #3091 +/- ##
=======================================
Coverage 91.33% 91.33%
=======================================
Files 204 204
Lines 8905 8905
=======================================
Hits 8133 8133
Misses 772 772 🚀 New features to boost your workflow:
|
Member
|
I have had constexpr matchers somewhere on my todo list for a while now. I am pretty sure that most/all of the generic matchers can be made constexpr compatible with fairly minimal changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR defines the default destructors for
MatcherGenericBaseandMatcherUntypedBaseinline, making them implicitly constexpr, meaning some matchers can be used in compile-time tests, e.g.:Unfortunately this currently only works with the
RangeEqualsmatchers, as the rest aren't constexpr, but that's still useful for implementing some constexpr tests without having to resort toREQUIRE(std::ranges::equal(a, b)), which results in less helpful output at runtimeThis has a small impact on compile times: